Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to save a reaction in server formats if text is present on the canvas #1444

Closed
ZhannaNovikova opened this issue Apr 14, 2022 · 5 comments
Assignees
Labels
bug external Issue depends on external services such as Indigo service
Milestone

Comments

@ZhannaNovikova
Copy link

**Steps to Reproduce **

  1. Launch Ketcher
  2. Create 2 structures
  3. Add the reaction arrow between them using the "Arrow Open Angle Tool" on the left menu
  4. Add a text using the "Add Text" on the left menu
  5. Click on the "Save as..." icon on the top menu
  6. Select any server format (e.g. MDL Rxnfile V3000) in the "File format" drop down

Expected behavior
The "Save Structure" dialog is opened successfully, without any errors for all File formats (The format is selected. It’s possible to save the file)

**Actual behavior **

Remote mode:

Error message “Convert error! struct data not recognized as molecule, query, reaction or reaction query” is displayed. 400 HTTP code is gotten.
With “SVG Document” and “PNG Image” formats the error message is not displayed. The 400 HTTP code is gotten after clicking on the “Save” button with the following description:
{
"error": "'struct data not recognized as molecule, query, reaction or reaction query'"
}

Standalone mode: The error message “Given string could not be loaded as (query or plain) molecule or reaction, see the error messages: 'reaction KET loader: Unknown reaction node: text', 'reaction KET loader: Unknown reaction node: text', 'molecule auto loader: Arrow nodes supported only for reactions', 'molecule auto loader: Arrow nodes supported only for reactions'" is displayed in the pop up window.

image

OS: [Microsoft Windows]
Browsers: Google Chrome: Version 100.0.4896.75/FireFox: Version 99.0 (64-bit)
Ketcher v2.4.2-158-g2312c8e8

@ZhannaNovikova ZhannaNovikova added the external Issue depends on external services such as Indigo service label Apr 14, 2022
@ZhannaNovikova
Copy link
Author

Related issue in the Indigo: epam/Indigo#705

@even1024
Copy link
Collaborator

Cannot reproduce it. Must be fixed in 1.6.3.

@ZhannaNovikova
Copy link
Author

Verified as fixed in the Version 1.6.5.0-g0e5aaceee-wasm32-wasm-clang-13.0.0

@ZhannaNovikova
Copy link
Author

Verified as fixed in the Standalone mode (Release 2.5.0).
The issue related to the Remote mode will be fixed in the [indigo-1.7] milestone.

@ZhannaNovikova
Copy link
Author

Verified as fixed on Release 2.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug external Issue depends on external services such as Indigo service
Projects
None yet
Development

No branches or pull requests

3 participants