Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's possible to create a custom template with a duplicate name #1553

Closed
Svetlana-Asinovskaia opened this issue May 2, 2022 · 3 comments · Fixed by #1594
Closed

It's possible to create a custom template with a duplicate name #1553

Svetlana-Asinovskaia opened this issue May 2, 2022 · 3 comments · Fixed by #1594
Assignees
Labels
Milestone

Comments

@Svetlana-Asinovskaia
Copy link
Collaborator

Svetlana-Asinovskaia commented May 2, 2022

Steps to Reproduce

  1. Launch Ketcher.
  2. Create a structure on the canvas.
  3. Click the 'Save as' button.
  4. Click the 'Save to Templates' button.
  5. In the 'Molecule name' field enter any name .
  6. Click the 'Apply' button.

Expected behavior
The user template with is saved to the User Templates - correct behavior.

  1. Repeat steps 3-6.

Expected behavior
An error 'Template must have a unique name...' is displayed. The 'Apply' button is disabled.

Actual behavior
A template with a duplicate name is saved to the User Templates.

Screenshots
2022-05-02_15h49_27

Desktop:

  • OS: Windows 10
  • Browser: Chrome
  • Version: 100.0.4896.127

Ketcher version:

  • v2.4.2-219-g11bc5160

Additional information:

  1. The error text ''Template must have a unique name...' overlaps the 'Molecule name' field.
  2. The behavior is as expected in 2.4.
@AnaMoskvina
Copy link
Contributor

if creation of templates with the same name doesn't cause any difficulties in usage, decided not to change behavior
approved @Alena-Guznischeva

@ZhannaNovikova
Copy link

The issue related to the behavior when the error text ''Template must have a unique name...' overlaps the 'Molecule name' field will be fixed in the separate task: #1599

@ZhannaNovikova
Copy link

Verified that the "Molecule name" field сannot be created with greater than 128 characters on Release 2.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants