Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal_application_error message label is unhelpful #116

Open
andrew-pickin-epi opened this issue Nov 24, 2022 · 1 comment
Open

internal_application_error message label is unhelpful #116

andrew-pickin-epi opened this issue Nov 24, 2022 · 1 comment
Assignees

Comments

@andrew-pickin-epi
Copy link

internal_application_error have a message label. Why?

Consider the following.

internal_application_error{message="Missing template application/render_404 with {:locale=>[:en], :formats=>[:json], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :jbuilder, :haml]}. Searched in:\n  * \"/usr/src/app/app/views\"\n  * \"/usr/local/bundle/gems/govuk_template-0.18.3/app/views\"\n  * \"/usr/local/bundle/gems/lr_common_styles-1.9.0/app/views\"\n"} 8.0
internal_application_error{message="Missing template application/render_404 with {:locale=>[:en], :formats=>[:css], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :jbuilder, :haml]}. Searched in:\n  * \"/usr/src/app/app/views\"\n  * \"/usr/local/bundle/gems/govuk_template-0.18.3/app/views\"\n  * \"/usr/local/bundle/gems/lr_common_styles-1.9.0/app/views\"\n"} 6.0

These are now classed as separate error types, when they shouldn't be.

@jonrandahl jonrandahl self-assigned this Jun 14, 2023
@tomguilbert
Copy link
Collaborator

tomguilbert commented Jun 15, 2023

Take the quantity message off the internal_application_error metric. Should be simple to do - if it isn't then push back to backlog.

@jonrandahl jonrandahl removed their assignment Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants