Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore why d is being passed via theta to primary_censored_integrand #31

Closed
Tracked by #34
seabbs opened this issue Sep 4, 2024 · 2 comments
Closed
Tracked by #34
Labels
bug Something isn't working

Comments

@seabbs
Copy link
Contributor

seabbs commented Sep 4, 2024

On the face of it I think theta should be for estimated parameters which d is not (its data) in all cases this may be having a performance impact

@seabbs seabbs added the bug Something isn't working label Sep 4, 2024
@seabbs
Copy link
Contributor Author

seabbs commented Sep 4, 2024

One of the reasons is that anything passed to x_r has be data and that this means that d has to be directly passed as data to the external stan wrapper function. This is currently a problem as these functions mutate d to add window to it.

One potential solution we could consider would be to use delay_lower and delay_upper in place of d and swindow. This would break some of the connection with the R code but should work (though it is hard to know if it is worth doing without trying).

One place this might be an issue is in the vectorised pmf function as this takes a single int and loops over the cdf. However, it may be the case that for loop index variables are privileged and so this won't be an issue.

@seabbs
Copy link
Contributor Author

seabbs commented Sep 6, 2024

This was closed by #44 by moving d to a data arg

@seabbs seabbs closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant