Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 55: Add fitdistdoublecens wrapper #61

Merged
merged 11 commits into from
Sep 10, 2024
Merged

Issue 55: Add fitdistdoublecens wrapper #61

merged 11 commits into from
Sep 10, 2024

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Sep 10, 2024

Description

This PR closes #55 by improving support for fitdistrplus vis a new wrapper function fitdistdoublecens. Unfortunately it does so by assigning temporary functions to the global environment as this was the only solution found to work with fitdistrplus. This means that it may not be CRAN compliant opening a new issue for this).

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

This comment was marked as outdated.

Copy link
Contributor Author

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (self-review)

@seabbs seabbs merged commit a0cb862 into main Sep 10, 2024
11 checks passed
@seabbs seabbs deleted the wrap-fitdistrplus branch September 10, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve integration with fitdistrplus
1 participant