Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouthwash Overhaul Assign Kits (Biospecimen) #1135

Open
Davinkjohnson opened this issue Oct 8, 2024 · 2 comments
Open

Mouthwash Overhaul Assign Kits (Biospecimen) #1135

Davinkjohnson opened this issue Oct 8, 2024 · 2 comments
Assignees
Labels
CCC Priority 1 Issues to be addressed in the current release

Comments

@Davinkjohnson
Copy link
Collaborator

(High Priority)

-This has a sequentially executed write process that can cause database inconsistencies where one operation succeeds and another fails. This can lead to hard-to-diagnose bugs and data inconsistencies.

  • Amber has already done work to firm up validation.

-we should check with Erin and Chris to see what issues have been found here.

@amber-emmes
Copy link
Collaborator

Just wanted to double-check... in the current workflow, if the count of participants found isn't exactly 1 (so if no participant is found or if two participants are found) it doesn't update any participant records, and it returns false, but it does still update the kit record. Is that desired behavior or should it change?

@sonyekere sonyekere added the CCC Priority 1 Issues to be addressed in the current release label Oct 9, 2024
@sonyekere
Copy link
Collaborator

Looping in @erincschwartz for potential feedback on Amber's question above.

@sonyekere sonyekere changed the title Mouthwash Overhaul Assign Kits Mouthwash Overhaul Assign Kits (Biospecimen) Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCC Priority 1 Issues to be addressed in the current release
Projects
Development

No branches or pull requests

4 participants