fix: make sure that suction pressure is less than or equal to dischar… #104
Conversation
| @@ -209,7 +209,19 @@ def _validate_operational_conditions( | |||
| discharge_pressure = np.where( | |||
| np.logical_and(np.min(rate, axis=0) <= 0, discharge_pressure <= 0), 1, discharge_pressure | |||
| ) | |||
|
|
|||
| if not np.all(discharge_pressure >= suction_pressure): | |||
There was a problem hiding this comment.
will this yield failure_status 0 and suction pressure or invalid discharge pressure (not sure which one is wrong in such a case...)
There was a problem hiding this comment.
Not straight forward to know if it is the suction or discharge pressure which is wrong. The validation will return INVALID_SUCTION_PRESSURE_INPUT.
| np.logical_and(np.min(rate, axis=0) <= 0, suction_pressure > discharge_pressure), | ||
| discharge_pressure, | ||
| suction_pressure, | ||
| ) |
There was a problem hiding this comment.
fairly complicated to read this numpy juggling. can it be extracted in a separate function and given some tests?
There was a problem hiding this comment.
Since we are now only validating input when rate != 0 the numpy juggling can be simplified a bit, it seems.
olelod
force-pushed
the
make-sure-suction-pressure-le-discharge-pressure
branch
from
156cf19
to
18a4ad5
Compare
| f" and rate is set to zero." | ||
| ) | ||
| rate = np.where(discharge_pressure < suction_pressure, 0, rate) | ||
| suction_pressure = np.where(suction_pressure > discharge_pressure, discharge_pressure, suction_pressure) |
There was a problem hiding this comment.
Why do we change suction pressure to discharge pressure here when it is not calculated (ie suction > discharge)? Will it not be confusing?
Good catch. On second thought I guess we don't need to change them. I was coloured by the similar checks against negative pressure - there we have to change them due to initialisation of fluids in NeqSim. |
…ge pressure for compressor train chore: add test of validation of operational conditions when suction pressure exceeds discharge pressure
olelod
force-pushed
the
make-sure-suction-pressure-le-discharge-pressure
branch
from
18a4ad5
to
8e683e6
Compare
…ge pressure for compressor train
Why is this pull request needed?
Suction pressure higher than discharge pressure gave negative enthalpy change over a compressor train and hence negative power.
What does this pull request change?
Validates that suction pressure is less than or equal to the discharge pressure for a compressor train. If the suction pressure is higher than the discharge pressure a failure status INVALID_SUCTION_PRESSURE_INPUT is given. In reality it could be either the suction pressure being too high or the discharge pressure being too low, but that will be up to the user to figure out...it can be hard to automatically detect which one it is.