fix: parse spaces as thousand separators from excel #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusrf
approved these changes
Jul 31, 2023
patnr
added a commit
to patnr/ecalc
that referenced
this pull request
Aug 21, 2023
* up-main: (65 commits) chore(docs): fix equations showing twice (equinor#141) chore: fix spelling errors in changelog chore(main): release 8.3.0 chore: add power adjustment constant also for compressor trains with interstage pressure (equinor#136) chore: fix typing of fluid composition docs: update docs and changelog for energy models (equinor#133) chore!: energy model type not allowed to change over time (equinor#131) docs: fix generic compressor example refactor: move NeqSimfluid creation into NeqSim wrapper chore: add 8.3 changelog chore: add fluid mixing checks ci: update pre-commit settings refactor: imrpove naming and documentation chore: add fluid mixing checks refactor: molar_mass_kg_per_mol is not used in the code fix: wrong standard_conditions_density when mixing two fluids test: add test for fluid stream mixing chore: merge queque fix: parse spaces as thousand separators from excel (equinor#107) refactor: NeqSim mapping (equinor#120) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
This pull request is needed because of wierd bug reported where thousand spacer was used and the error was not catched until NeqSim threw an NaN error
What does this pull request change?
Removes initial and separator spaces when reading csvs
Issues related to this change:
closes: https://github.com/equinor/ecalc-engine/issues/4661