Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate system v2 schema #161

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

jsolaas
Copy link
Contributor

@jsolaas jsolaas commented Sep 11, 2023

No description provided.

@jsolaas jsolaas requested review from a team as code owners September 11, 2023 13:37
@@ -24,6 +24,8 @@ repos:
- id: codespell
name: Check for typos in code
additional_dependencies: [tomli]
exclude_types:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is it complaining on?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n or that we have a lot of typos in docstrings? or that it doesnt make sense because there are non-words that we dotn want to fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complained about nin not being correct, combination of \n and in without space

@jsolaas jsolaas force-pushed the refactor/generate-system-v2-schema branch from cdc3221 to 0fab706 Compare September 11, 2023 17:24
@jsolaas jsolaas merged commit a27c392 into main Sep 11, 2023
4 checks passed
@jsolaas jsolaas deleted the refactor/generate-system-v2-schema branch September 11, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants