Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: what fluid to recirculate when there is no rate entering a compressor stage in a multiple streams compressor train at a given time step #164

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

olelod
Copy link
Contributor

@olelod olelod commented Sep 12, 2023

This regards VairableSpeedCompressorTrainCommonShaftMultipleStreamsAndPressures only. In situations where there is both an additional ingoing stream and an additional ingoing stream between two compressors, one can end up with a situation where one tries to mix together two streams with zero mass rate (to mix the one stream passing from compressor 1 to compressor 2 and the additional stream entering the compressor train between compressor 1 and compressor 2). This means that if we look at this time step isolated there is an unknown composition to recirculate in the second compressor. This fluid to recirculate should have the same composition as the fluid passing through the second compressor at the previous time step.

What does this pull request change?

  • Includes a class attribute keeping track of the composition of the fluid passing through the different compressor stages in a compressor train, such that it will be available for the next time step (except for the first time step - there the code will fail)
  • A small fix giving the correct standard condition density for the resulting fluid with mixing two fluids (now using the correct pressure and temperature, instead of assuming that the given pressure and temperature is the standard condition pressure and standard condition temperature)
  • Adding a test

@olelod olelod self-assigned this Sep 12, 2023
@olelod olelod changed the title fix: what fluid to recirculate when there is no rate entering a multiple streams compressor train at a given time step fix: what fluid to recirculate when there is no rate entering a compressor stage in a multiple streams compressor train at a given time step Sep 12, 2023
@olelod olelod marked this pull request as ready for review September 12, 2023 08:16
@olelod olelod requested a review from a team as a code owner September 12, 2023 08:16
@olelod olelod force-pushed the mix-streams-zero-mass-rate branch 2 times, most recently from 70baee2 to 8786eea Compare September 12, 2023 11:00
@olelod olelod force-pushed the mix-streams-zero-mass-rate branch 2 times, most recently from be81fa9 to 4ea8210 Compare September 13, 2023 11:53
@frodehk frodehk self-requested a review September 14, 2023 08:06
…sor stage in a multiple streams compressor train

chore: calculate correct standard condition density when mixing two streams

chore: adding test of full recirculation in multiple streams compressor trains
@olelod olelod merged commit ba9235e into main Sep 14, 2023
6 checks passed
@olelod olelod deleted the mix-streams-zero-mass-rate branch September 14, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants