refactor: improve error message when wrong CURVE-keyword input to single speed compressor #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frodehk
force-pushed
the
ECALC-20-error-message-wrong-yaml-name-compressor-curve
branch
from
d74a73f
to
5c3b83c
Compare
jsolaas
approved these changes
Sep 14, 2023
src/ecalc/libraries/libecalc/common/libecalc/input/mappers/model.py
Outdated
Show resolved
Hide resolved
frodehk
deleted the
ECALC-20-error-message-wrong-yaml-name-compressor-curve
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
Keyword
CURVESis reserved for variable speed compressors only. Single speed compressors should use the keywordCURVE. Due to the obvious similarity it is a risk that the user mixes the two, e.g. usingCURVESfor single speed compressors. When this happens the error message is difficult to understand.What does this pull request change?
CURVESis used for single speed compressor modelsIssues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-20?atlOrigin=eyJpIjoiOTBjOWU5M2VjOGQwNDdmOWFkOWIxYjlhM2ExYThmNTQiLCJwIjoiaiJ9