fix: remove inlet actual rate in compressor sampled results #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olelod
changed the title
olelod
changed the title
TeeeJay
reviewed
Sep 18, 2023
| @@ -226,7 +226,6 @@ def evaluate_rate_ps_pd( | |||
| power_unit=Unit.MEGA_WATT, | |||
| inlet_stream_condition=CompressorStreamCondition( | |||
| pressure=list(suction_pressure) if suction_pressure is not None else None, | |||
| actual_rate_m3_per_hr=list(rate) if rate is not None else None, | |||
There was a problem hiding this comment.
Add a comment here or in CompressorStreamCondition to specify what you mentioned in the PR comment that knowing fluid_density is a requirement to set this, to avoid doing the same mistake in the future, and to bring awareness?
TeeeJay
approved these changes
Sep 18, 2023
olelod
force-pushed
the
ECALC-167-actual-rate-in-compressor-sampled
branch
from
5b1868f
to
4c96b09
Compare
…e it can not be calculated
olelod
force-pushed
the
ECALC-167-actual-rate-in-compressor-sampled
branch
from
4c96b09
to
82b0490
Compare
olelod
changed the title
jsolaas
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
The input rate (in Sm3) has been returned as the actual rate (in Am3) for compressor trains of type compressor_sampled. This is obviously not correct, since we need information about fluid density to calculate the actual rate.