feat: multiple streams in system #242
Conversation
jsolaas
force-pushed
the
feat/multiple-streams-in-system
branch
from
51a533f
to
b4aaa4f
Compare
| @@ -15,6 +15,7 @@ class Config: | |||
| alias_generator = to_camel_case | |||
| allow_population_by_field_name = True | |||
|
|
|||
| name: Optional[str] | |||
| rate: TimeSeriesRate | |||
There was a problem hiding this comment.
I guess we need either a (unique) name or an id to attach a stream to a compressor stage when we later allow for streams going into/out of any compressor stage.
Also consider including temperature here and the full fluid model/composition, not just the density.
There was a problem hiding this comment.
I agree, the plan is to implement that in another PR. I'm thinking a unique name for a stream within a component makes sense.
| - NAME: in_stream_crossover_1 | ||
| FROM: compressor2 | ||
| TO: compressor1 | ||
| - FROM: compressor3 |
| - NAME: compressor1 | ||
| ENERGY_USAGE_MODEL: compressor_with_turbine | ||
| - NAME: compressor2 | ||
| ENERGY_USAGE_MODEL: compressor_sampled_1d | ||
| - NAME: compressor3 | ||
| ENERGY_USAGE_MODEL: compressor_sampled_1d |
There was a problem hiding this comment.
Should only consume power, not fuel
jsolaas
force-pushed
the
refactor/change-crossover-syntax
branch
from
7b6b47b
to
088b4d5
Compare
jsolaas
force-pushed
the
feat/multiple-streams-in-system
branch
from
b4aaa4f
to
90741ff
Compare
jsolaas
force-pushed
the
refactor/change-crossover-syntax
branch
from
088b4d5
to
11c2581
Compare
jsolaas
force-pushed
the
feat/multiple-streams-in-system
branch
2 times, most recently
from
99f689e
to
6e90c4b
Compare
| @@ -242,6 +242,7 @@ | |||
| 2.0 | |||
| ] | |||
| }, | |||
| "name": null, | |||
There was a problem hiding this comment.
I think we should enforce it ... or generate it
| @@ -95,6 +96,54 @@ def __init__( | |||
| # previous time step to recirculate. This will take care of that. | |||
| self.fluid_to_recirculate_in_stage_when_inlet_rate_is_zero = [None] * len(self.stages) | |||
|
|
|||
| def evaluate_streams( | |||
There was a problem hiding this comment.
It seems that this is not in use yet, just making it ready? Is that so? Possible to use it, and e.g. enable it with a feature flag? Or is it not ready?
There was a problem hiding this comment.
Used in v2. I'm overwriting the parent method so there is no change where it is used.
jsolaas
force-pushed
the
feat/multiple-streams-in-system
branch
from
6e90c4b
to
1e06c6d
Compare
Multiple streams can be used to handle crossover streams individually in a train. Currently no additional streams can be given, as the system does not support providing several rates/streams per consumer.
jsolaas
force-pushed
the
feat/multiple-streams-in-system
branch
from
1e06c6d
to
fc69915
Compare
Multiple streams can be used to handle crossover streams individually in a train. Currently no additional streams can be given, as the system does not support providing several rates/streams per consumer.
Multiple streams can be used to handle crossover streams individually in a train. Currently no additional streams can be given, as the system does not support providing several rates/streams per consumer.