refactor: use Graph object to build graph #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proper graph implementation, isolate networkx and implementation details.
jsolaas
force-pushed
the
refactor/graph-details
branch
from
489452e
to
f05538c
Compare
TeeeJay
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Nice, one step on the way to make core agnostic about dependencies :)
We need to give both graph, node and edge proper names related to the domain though (imo). Such as EnergyNetwork (PowerNetwork, fuel network etc) or Piping System (TBD), whatever it is called, but then internally we use a graph, so that the Graph is never exposed to users.
pipingSystem.addPipeline(..,..)
pipeline.connect(...,...)
etc?
equinor-schen
pushed a commit
that referenced
this pull request
Nov 22, 2023
Proper graph implementation, isolate networkx and implementation details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper graph implementation, isolate networkx and implementation details.