chore: make sure no mismatch between timestemps and time series values #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
TeeeJay
reviewed
Oct 24, 2023
TeeeJay
reviewed
Oct 24, 2023
TeeeJay
requested changes
Oct 24, 2023
frodehk
commented
Oct 27, 2023
frodehk
force-pushed
the
ECALC-313-ensure-consistent-timesteps-values
branch
from
22eca81
to
26d60e8
Compare
TeeeJay
reviewed
Nov 1, 2023
TeeeJay
reviewed
Nov 1, 2023
TeeeJay
approved these changes
Nov 1, 2023
frodehk
force-pushed
the
ECALC-313-ensure-consistent-timesteps-values
branch
from
05eb98c
to
48fc124
Compare
equinor-schen
pushed a commit
that referenced
this pull request
Nov 22, 2023
#251) * chore: make sure no mismatch between timestemps and time series values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
When there is a mismatch between number timesteps and number of time series values, this may be silently ignored. The danger is that a single value or few values are extrapolated, or mapped incorrectly, and therefore getting wrong results.
We should make sure that we always have a 1:1 relationshop between timesteps and values when working with timeseries to make sure that this cannot be a problem.
What does this pull request change?
TimeSeriesto ensure there is no mismatch between timesteps and values.Issues related to this change: