refactor: move validate operational conditions from compressor train #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olelod
force-pushed
the
refactor-move-validate-operational-conditions-out-of-compressor-train
branch
2 times, most recently
from
e7c294a
to
4bee347
Compare
jsolaas
approved these changes
Oct 27, 2023
jsolaas
reviewed
Oct 27, 2023
Comment on lines
+63
to
+64
| # any remaining zero or negative suction/discharge pressures (for unvalidated time steps, others are already changed) | ||
| # must be set to 1 (for neqsim to initiate fluid streams) |
There was a problem hiding this comment.
Why do we have unvalidated timesteps, and why is the pressure values relevant then? Unvalidated has zero rate or negative as far as I understand. I assume it is related to multiple streams, but not sure
There was a problem hiding this comment.
I actually think it is the current implementation of simplified train that requires it.
(
)
… rename to validate model input chore: add ModelInputFailureStatus chore: fix tests
olelod
force-pushed
the
refactor-move-validate-operational-conditions-out-of-compressor-train
branch
from
4bee347
to
03d0087
Compare
olelod
deleted the
refactor-move-validate-operational-conditions-out-of-compressor-train
branch
equinor-schen
pushed a commit
that referenced
this pull request
Nov 22, 2023
… rename to validate model input (#256) chore: add ModelInputFailureStatus chore: fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename validate_operational_conditions to validate_model_input because it is validation of model input.
Move the validation out of compressor train, since model input of other models (such as pumps) should also be validated in the same way.
Adding ModelInputFailureStatus enum to keep track of valid/invalid model input.