-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong handling of values and timesteps in temporal models #261
fix: wrong handling of values and timesteps in temporal models #261
Conversation
d4cd52d
to
ce8dc82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good, but all snapshots are expanding null
to NaN
..I guess we have no cases where real values are actually overwritten? Good with test. Need UAT to have a look to QA this :) Good job though :)
Yes, I think None is resolved to null in json (?). And, None is now filled with nans to ensure correct number of values vs timesteps. |
8f63a7d
to
47f2fac
Compare
47f2fac
to
7b69ff0
Compare
* fix: wrong handling of values and timesteps in temporal models
Why is this pull request needed?
Problem when extending time series for compressors across temporal models in
EnergyModelBaseResult.extend()
. This is basically related to how None-values are treated. Two bugs:None
and next temporal model contains real values, the merge/extend function evaluates toNone
- ignoring data from second temporal model.None
, the merge/extend function evaluates to the values of the first temporal model. The timesteps in the second model are ignored, hence a mismatch between number of timesteps and number of values are introduced for the actual time series.What does this pull request change?
CompressorTrainResultSingleStep
: Ensure that all time series have values or NaN for all valid timesteps, even if input isNone
CompressorModelSampled
: Ensure that all time series have values or NaN for all valid timesteps, even if input isNone
Issues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-376?atlOrigin=eyJpIjoiNzY4MzVlMWU2ZjEzNDMwNzhiYzNhMDZkMmExYzljOTQiLCJwIjoiaiJ9