Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use common consumer system dto class #267

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

jsolaas
Copy link
Contributor

@jsolaas jsolaas commented Nov 1, 2023

Why is this pull request needed?

No need to have separate systems for pump and compressor

What does this pull request change?

Creates ConsumerSystem instead of Pump- and CompressorSystem in dto.

Issues related to this change:

@jsolaas jsolaas requested a review from a team as a code owner November 1, 2023 10:27
Copy link
Collaborator

@TeeeJay TeeeJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked that this was doable now :)

@jsolaas jsolaas merged commit 3c58b53 into main Nov 2, 2023
6 checks passed
@jsolaas jsolaas deleted the refactor/single-system-dto branch November 2, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants