feat: include rate type in header for csv export #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsolaas
approved these changes
Nov 14, 2023
frodehk
deleted the
ECALC-444-include-rate-type-in-header-for-csv-export
branch
equinor-schen
pushed a commit
that referenced
this pull request
Nov 22, 2023
* feat: include rate type in header for csv export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
It is currently not possible to see if time series rates are calendar day- or stream day rates in the csv export file. This can make it difficult for user to know if regularity is included or not in the results.
What does this pull request change?
sd/cdinstead ofdin csv-header, to indicateSTREAM_DAYorCALENDAR_DAYMW (sd)Sm3 (cd)Issues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-444?atlOrigin=eyJpIjoiMDRiMGI4NTY5M2Y1NDUzOGI3OTY3NzFiM2MwOTJiZmYiLCJwIjoiaiJ9