chore: add maximum rate of compressor train to CompressorModelResult #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olelod
force-pushed
the
ECALC-250-calculate-max-rate-does-not-seem-to-work-for-pr-fluid-type
branch
3 times, most recently
from
bc365c9
to
9a4f11d
Compare
olelod
force-pushed
the
ECALC-250-calculate-max-rate-does-not-seem-to-work-for-pr-fluid-type
branch
from
9a4f11d
to
e58b70b
Compare
TeeeJay
reviewed
Nov 21, 2023
TeeeJay
reviewed
Nov 21, 2023
| ], | ||
| "unit": "Sm3/d", | ||
| "values": [ | ||
| null, |
There was a problem hiding this comment.
All snapshots show null as values for max rate. Expected? Are we able to find a real max rate that actually verifies the functionality?
olelod
force-pushed
the
ECALC-250-calculate-max-rate-does-not-seem-to-work-for-pr-fluid-type
branch
from
e58b70b
to
f4170f6
Compare
TeeeJay
approved these changes
Nov 21, 2023
olelod
force-pushed
the
ECALC-250-calculate-max-rate-does-not-seem-to-work-for-pr-fluid-type
branch
2 times, most recently
from
44120a6
to
b169cdb
Compare
olelod
force-pushed
the
ECALC-250-calculate-max-rate-does-not-seem-to-work-for-pr-fluid-type
branch
from
b169cdb
to
3d98f1f
Compare
olelod
force-pushed
the
ECALC-250-calculate-max-rate-does-not-seem-to-work-for-pr-fluid-type
branch
from
3d98f1f
to
0f5364b
Compare
test: update tests with maximum rate chore: update snapshot
olelod
force-pushed
the
ECALC-250-calculate-max-rate-does-not-seem-to-work-for-pr-fluid-type
branch
from
0f5364b
to
43eff7a
Compare
olelod
deleted the
ECALC-250-calculate-max-rate-does-not-seem-to-work-for-pr-fluid-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
Maximum (standard) rate was only found inside of operational settings results. This PR adds maximum rate (removed standard, since the Unit og the TimeSeriesRate carries the Sm3/day information).
As for the rate, as a workaround at this point only the maximum rate for the first stream is reported.