refactor: change emission rate type to calendar day #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeeeJay
reviewed
Nov 23, 2023
| @@ -48,7 +48,7 @@ def aggregate_emissions( | |||
| emissions_aggregated[emission_name] = PartialEmissionResult( | |||
| name=emission_name, | |||
| timesteps=emissions[0].timesteps, | |||
| rate=reduce(operator.add, [emission.rate for emission in emissions]), | |||
| rate=reduce(operator.add, [emission.rate.to_calendar_day() for emission in emissions]), | |||
There was a problem hiding this comment.
here the rate should already be calendar day I guess, but it doesn hurt to be sure at least ;)
There was a problem hiding this comment.
When I checked (I think), it seemed to be stream:-)
TeeeJay
approved these changes
Nov 23, 2023
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
Emission rate type should be
CALENDAR_DAY, the same as for fuel rate.What does this pull request change?
CALENDAR_DAYIssues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-495?atlOrigin=eyJpIjoiZGY1YTA5OThkYjc1NGVmNjgxNjIxOTNiYzAwMzBmZjAiLCJwIjoiaiJ9