chore: define yaml classes for remaining elements in MODELS #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsolaas
reviewed
Dec 1, 2023
Comment on lines
+94
to
+95
| def to_dto(self): | ||
| raise NotImplementedError |
There was a problem hiding this comment.
I think it is a mistake to define this as needed in YamlBase, as I have done currently.
There was a problem hiding this comment.
You mean it should be defined in YamlBase instead?
There was a problem hiding this comment.
no, it doesnt matter that much. We want to skip dtos completely, and map directly to domain. dtos are no longer needed, but we will need some clever ways to map to domain. WIP :)
jsolaas
approved these changes
Dec 14, 2023
frodehk
deleted the
ECALC-505-define-yaml-classes-for-elements-in-models
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
Add classes for remaining elements in MODELS, for use with V2.
What does this pull request change?
STAGESINGLE_SPEED_COMPRESSOR_TRAINVARIABLE_SPEED_COMPRESSOR_TRAINSIMPLIFIED_VARIABLE_SPEED_COMPRESSOR_TRAINVARIABLE_SPEED_COMPRESSOR_TRAIN_MULTIPLE_STREAMS_AND_PRESSURESIssues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-505?atlOrigin=eyJpIjoiYzMwMGYwZTgyMDZhNGUwOTkzODAzZTliNWU0ZWNjMDAiLCJwIjoiaiJ9