chore: change ltp-filter for oil loaded/stored #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frodehk
force-pushed
the
ECALC-124-change-filter-oil-loaded-stored
branch
from
f0bb152
to
abfea32
Compare
TeeeJay
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
Currently,
Total Oil Loaded/Storedis filtered by the categorySTORAGE. There's not always storage related emissions for loaded oil. But all known use cases with storage emissions also have loading emissions, so the category should be changed toLOADINGto avoid post-processing/workarounds.What does this pull request change?
Total Oil Loaded/StoredtoLOADINGIssues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-124?atlOrigin=eyJpIjoiN2IzYzZiNmMxNTczNGUxMjkwOWY2NmU1MTY5ODQ4YTYiLCJwIjoiaiJ9