fix: expression error messages #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsolaas
commented
Jan 29, 2024
| @@ -10,6 +10,7 @@ | |||
| from pydantic_core import CoreSchema, core_schema | |||
| from pydantic_core.core_schema import ValidationInfo | |||
|
|
|||
| from libecalc.common.errors.exceptions import EcalcError | |||
There was a problem hiding this comment.
This is wrong if we are trying to make expression module independent of ecalc.
jsolaas
force-pushed
the
fix/expression-errors
branch
2 times, most recently
from
f7cf6f2
to
1ad7eb1
Compare
ketwik
approved these changes
Jan 30, 2024
jsolaas
force-pushed
the
fix/expression-errors
branch
2 times, most recently
from
09ca311
to
adae2ef
Compare
jsolaas
force-pushed
the
fix/expression-errors
branch
from
adae2ef
to
2b78d5f
Compare
equinor-schen
pushed a commit
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.