Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fixed the Error in Simple model example in eCalc Docs, variable name started from salt_water to sea_water in full eCalc YAML model #369

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

equinor-schen
Copy link
Contributor

No description provided.

@equinor-schen equinor-schen requested a review from a team as a code owner February 2, 2024 13:00
@equinor-schen
Copy link
Contributor Author

The error in Simple model example YAML file in eCalc Docs had been fixed; variable $var.salt_water... had been corrected to $var.sea_water... Please take a review.

Copy link

@HeddaSvendsen HeddaSvendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update line 156 as well, see picture below:
image

@equinor-schen equinor-schen force-pushed the ECALC-320-Error_in_Simple_model_example_in_eCalc_Docs branch from bb12458 to 0adde50 Compare February 2, 2024 14:27
@equinor-schen
Copy link
Contributor Author

Line 156 had been update with $var.sea_water.

… name started from salt_water to sea_water in full eCalc YAML model
@olelod olelod force-pushed the ECALC-320-Error_in_Simple_model_example_in_eCalc_Docs branch from d92ac1b to a9caf23 Compare February 6, 2024 13:09
@olelod olelod merged commit 2961d2f into main Feb 6, 2024
6 checks passed
@olelod olelod deleted the ECALC-320-Error_in_Simple_model_example_in_eCalc_Docs branch February 6, 2024 13:13
equinor-schen added a commit that referenced this pull request Aug 23, 2024
… name started from salt_water to sea_water in full eCalc YAML model (#369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants