refactor: allow str in resource stream #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing str in resource stream allows for a simpler interface for a resource with a name and read function where we already have the str.
jsolaas
force-pushed
the
refactor/simplify-resource-stream
branch
from
7b4734c
to
9a93e49
Compare
markusrf
approved these changes
Feb 5, 2024
jsolaas
added a commit
that referenced
this pull request
Feb 5, 2024
This reverts commit fe9f3f2. Overlooked the parameters given to read, i.e. size is passed to read but ignored for str type.
jsolaas
added a commit
that referenced
this pull request
Feb 5, 2024
equinor-schen
pushed a commit
that referenced
this pull request
Aug 23, 2024
Allowing str in resource stream allows for a simpler interface for a resource with a name and read function where we already have the str.
equinor-schen
pushed a commit
that referenced
this pull request
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing str in resource stream allows for a simpler interface for a resource with a name and read function.