fix: use yaml expression type for installation #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves error messages for hcexport and regularity
jsolaas
commented
Mar 19, 2024
| @@ -9,8 +9,6 @@ | |||
| ) | |||
| from libecalc.presentation.yaml.yaml_types.yaml_variable import YamlSingleVariable | |||
|
|
|||
| # from libecalc.presentation.yaml.yaml_types import YamlSingleVariable | |||
There was a problem hiding this comment.
YamlVariables still do not use YamlExpressionType, this is because we expect the type to be parsed into an expression. YamlExpressionType only validates. We should look into parsing into an expression in YamlExpressionType I think, if we go that route we probably don't need to implement pydantic specific methods in expression.py (__get_pydantic_core_schema__ etc.). The alternative is to make expression.py validate similar to YamlExpressionType and use that in the Yaml classes.
TeeeJay
approved these changes
Mar 19, 2024
equinor-schen
pushed a commit
that referenced
this pull request
Aug 23, 2024
Improves error messages for hcexport and regularity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves error messages for hcexport and regularity