fix: maximum rate for simplified compressor train #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olelod
commented
Apr 3, 2024
| @@ -411,7 +411,7 @@ def get_max_standard_rate( | |||
| # The second (1-index) axis of stages_maximum_standard_rates - each numpy array - represent each of the input | |||
| # pressure points | |||
| # Want to calculate the maximum over all stages, hence use axis=0 in numpy.amax | |||
| maximum_rates = np.amax( | |||
| maximum_rates = np.amin( | |||
There was a problem hiding this comment.
It was even written in the docstring, yet implemented the other way around...
jsolaas
approved these changes
Apr 3, 2024
chore: update snapshots
olelod
force-pushed
the
maximum_rate_for_simplified_train
branch
from
697e444
to
a4a2c32
Compare
equinor-schen
pushed a commit
that referenced
this pull request
Aug 23, 2024
chore: update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating the maximum standard rate for a simplified compressor train we first find the maximum rate for the individual stages. The maximum for the train should be the minimum of the maximum rates for the individual stages. Currently we use the maximum of the maximum rates for the individual stages.