fix: error when only venting emitters are specified for an installation #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missing ECALC-1061
jsolaas
reviewed
Apr 26, 2024
ECALC-1061
Have added this check: |
jsolaas
approved these changes
May 2, 2024
frodehk
added a commit
that referenced
this pull request
May 2, 2024
* fix: error when only venting emitters are specified for an installation (#449) * fix: error when only venting emitters due to installation regularity missing ECALC-1061 (cherry picked from commit 017560d) * chore: update yaml oil type venting emitter (#448) ECALC-1060 (cherry picked from commit 7997813)
equinor-schen
pushed a commit
that referenced
this pull request
Aug 23, 2024
…on (#449) * fix: error when only venting emitters due to installation regularity missing ECALC-1061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECALC-1061
Why is this pull request needed?
Error when venting emitters are defined alone, without a generator set - for a given installation. The reason is that the installation results are empty, and the installation regularity cannot be found for the particular venting emitters.
What does this pull request change?
More robust reading of regularity for venting emitters, independent of installation results: Reading from the asset object directly.
Issues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-1061?atlOrigin=eyJpIjoiNWUwMDMwMjkxMzc2NGEyMmJmMGY5ZTg3NTBlOThkZDQiLCJwIjoiaiJ9