Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: numpy ndarray typing #46

Merged
merged 1 commit into from
Jun 6, 2023
Merged

refactor: numpy ndarray typing #46

merged 1 commit into from
Jun 6, 2023

Conversation

olelod
Copy link
Contributor

@olelod olelod commented May 31, 2023

No description provided.

@olelod olelod marked this pull request as ready for review June 6, 2023 06:56
@olelod olelod requested a review from a team as a code owner June 6, 2023 06:56
TeeeJay
TeeeJay approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@TeeeJay TeeeJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job. let's see where we end up wrt the granularity of type hints. Was there a mypy flag that could be checked/crossed out after this job? Or to remove numpy from an ignore list?

@olelod
Copy link
Contributor Author

olelod commented Jun 6, 2023

nice job. let's see where we end up wrt the granularity of type hints. Was there a mypy flag that could be checked/crossed out after this job? Or to remove numpy from an ignore list?

There are a lot less e.g. [type-arg] complaints, but they are not fully gone.

@olelod olelod merged commit 9b7b308 into main Jun 6, 2023
@olelod olelod deleted the fix-numpy-typing branch June 6, 2023 11:39
@github-actions github-actions bot mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeeeJay TeeeJay TeeeJay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olelod @TeeeJay