fix: max power from shore values #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeeeJay
reviewed
May 21, 2024
|
also, when did this bug occur? please update jira issue, and if relevant add to changelog if that occured before 8.15 |
Have updated Jira-issue |
ECALC-1189
ECALC-1189
ECALC-1189
ECALC-1189
ECALC-1189
frodehk
force-pushed
the
ECALC-1189-fix-max-pfs-values
branch
from
a94906f
to
ec6c6e5
Compare
TeeeJay
approved these changes
May 21, 2024
ECALC-1189
frodehk
added a commit
that referenced
this pull request
May 22, 2024
* fix: max power from shore values ECALC-1189 (cherry picked from commit 1c7a4a1)
frodehk
added a commit
that referenced
this pull request
May 22, 2024
equinor-schen
pushed a commit
that referenced
this pull request
Aug 23, 2024
* fix: max power from shore values ECALC-1189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECALC-1189
Have you remembered and considered?
docs/docs/changelog/next.md)docs/docs/migration_guides/)BREAKING:in footer or!in header, if breakingECALC-XXXX)Why is this pull request needed?
Max Usage from Shore: Output values does not correspond to input in LTP-report when output frequency is set to e.g.YEAR. It is because theMax Usage from Shoreis handled as TimeSeriesVolume. This is not correct. TheMax Usage from Shoreis the peak load/effect that is expected within an hour, per year. Hence, it should not be handled as volumes. The input from the user is what should be reported in LTP, just reindexed so that it matches the timesteps.What does this pull request change?
Max Usage from Shore: Handle asTimeSeriesFloatIssues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-1189?atlOrigin=eyJpIjoiYmI4ZmQ4Mjk0ZTFiNDEyYWJjMzhlY2ViMDFlYjJlN2EiLCJwIjoiaiJ9