Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error message for new pfs columns #511

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

frodehk
Copy link
Contributor

@frodehk frodehk commented Jun 4, 2024

ECALC-1267

Have you remembered and considered?

  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Jira issue ID somewhere in the commit body (ECALC-XXXX)

Why is this pull request needed?

Error occurs when creating error message related to wrong category for power from shore columns/variables (CABLE_LOSS and MAX_USAGE_FROM_SHORE only valid for category POWER_FROM_SHORE)

What does this pull request change?

Use model_fields to obtain titles/names in error message.

Issues related to this change:

https://equinor-ecalc.atlassian.net/browse/ECALC-1267?atlOrigin=eyJpIjoiZWMzNDlhNTI5NmM0NDkwMTgwNTljZTM1ZmQ3NWNkM2QiLCJwIjoiaiJ9

@frodehk frodehk self-assigned this Jun 4, 2024
@frodehk frodehk requested a review from a team as a code owner June 4, 2024 11:28
Copy link
Collaborator

@TeeeJay TeeeJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible to have a small test for this?

@frodehk frodehk merged commit 7b4ea11 into main Jun 4, 2024
9 checks passed
@frodehk frodehk deleted the ECALC-1267-fix-error-message-pfs-columns branch June 4, 2024 12:03
@frodehk
Copy link
Contributor Author

frodehk commented Jun 4, 2024

Sorry, didn´t see your comment before merging:-) Will have a look at the testing. Challenge is that the validation is different in cli vs web.

equinor-schen pushed a commit that referenced this pull request Aug 23, 2024
* fix: error message for new pfs columns

ECALC-1267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants