-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update advanced model #522
Conversation
ECALC-531 ECALC-530
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
I'm assuming the yaml has changed here also? It would be easier to see the changes if moving into files and changes was separated. The renaming of advanced from md to mdx is also not captured, so it looks like a delete and create instead. Not sure how important that is, someone else should probably verify the actual content :)
ECALC-531
I agree, it was all in one go. The yaml-content has changed as well, more advanced model. The original yaml (advanced) is now under course content. The simple model in examples and course content is identical for now. The simple model is updated (input file update only) in a separate PR. |
ECALC-531
* docs: update advanced model ECALC-531
ECALC-531
Have you remembered and considered?
ECALC-XXXX
)Why is this pull request needed?
Update examples in eCalc docs to be representative and avoid invalid timesteps. This can be confusing for externals.
What does this pull request change?
Issues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-531?atlOrigin=eyJpIjoiODc3MmU1MmEyNWIzNGVkYTg1YTRmZDBlYjc0OTg4MWYiLCJwIjoiaiJ9