Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update documentation about fluid models adding missing yaml key… #524

Merged
merged 1 commit into from
Jun 13, 2024
Merged

docs: update documentation about fluid models adding missing yaml key… #524

merged 1 commit into from
Jun 13, 2024

Conversation

olelod
Copy link
Contributor

@olelod olelod commented Jun 11, 2024 •
edited
Loading

…words

ECALC-1231
ECALC-1232
ECALC-1233
ECALC-1234

Have you remembered and considered?

  • I have remembered to update documentation
  • I have remembered to update manual changelog (docs/docs/changelog/next.md)
  • I have remembered to update migration guide (docs/docs/migration_guides/)
  • I have committed with BREAKING: in footer or ! in header, if breaking
  • I have added tests (if not, comment why)
  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Jira issue ID somewhere in the commit body (ECALC-XXXX)

@olelod olelod force-pushed the docs-clean-up-fluid-modeling branch 2 times, most recently from d9a7973 to 69a4fad Compare June 12, 2024 08:12
@olelod olelod marked this pull request as ready for review June 12, 2024 08:13
@olelod olelod requested a review from a team as a code owner June 12, 2024 08:13
HeddaSvendsen
HeddaSvendsen approved these changes Jun 13, 2024
View reviewed changes
Copy link

@HeddaSvendsen HeddaSvendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@olelod
docs: update documentation about fluid models adding missing yaml key…
23a0ce8 
…words

ECALC-1231
ECALC-1232
ECALC-1233
ECALC-1234
@olelod olelod force-pushed the docs-clean-up-fluid-modeling branch from 69a4fad to 23a0ce8 Compare June 13, 2024 20:23
@olelod olelod merged commit 8bd68a1 into main Jun 13, 2024
9 checks passed
@olelod olelod deleted the docs-clean-up-fluid-modeling branch June 13, 2024 20:26
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Merged
equinor-schen pushed a commit that referenced this pull request Aug 23, 2024
@olelod @equinor-schen
docs: update documentation about fluid models adding missing yaml key…
64846ef 
…words (#524)

ECALC-1231
ECALC-1232
ECALC-1233
ECALC-1234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeddaSvendsen HeddaSvendsen HeddaSvendsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olelod @HeddaSvendsen