chore: make sure that pressure calculation tolerances are the same at… #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olelod
force-pushed
the
use-same-pressure-calculation-tolerance-everywhere
branch
from
91371e6
to
6eb9645
Compare
frodehk
approved these changes
Aug 22, 2024
|
@olelod ok to merge - and also to create a patch for 8.20 release as well - to be patched this week |
… different places in the code chore: update snapshots ECALC-1533
olelod
force-pushed
the
use-same-pressure-calculation-tolerance-everywhere
branch
from
6eb9645
to
92b2379
Compare
frodehk
pushed a commit
that referenced
this pull request
Sep 16, 2024
… different places in the code (#532) chore: update snapshots ECALC-1533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… different places in the code
Have you remembered and considered?
docs/docs/changelog/next.md)docs/docs/migration_guides/)BREAKING:in footer or!in header, if breakingECALC-XXXX)Why is this pull request needed?
Pressure calculation tolerance in the iteration to find the outlet pressure of a compressor stage had a tolerance of 0.01, while other tolerances inside the code were set to 0.001. This led to edge cases where there should be a solution but seemingly the target pressure of a compressor stage was not met (calculated pressure with too large relative difference from the target pressure).
What does this pull request change?
Removing the constant OUTLET_PRESSURE_CONVERGENCE_TOLERANCE and using the constant PRESSURE_CALCULATION_TOLERANCE everywhere.
Results have changed in tests because the calculation is more accurate (adding iterations in the calculation of the outlet pressure of a compressor stage).
Refs.
ECALC-1533