chore: improve error messages for invalid characters in variables names #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsolaas
approved these changes
Jun 21, 2024
equinor-schen
pushed a commit
that referenced
this pull request
Aug 23, 2024
…es (#536) * chore: improve error messages for invalid characters in variables names ECALC-647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECALC-647
Have you remembered and considered?
ECALC-XXXX)Why is this pull request needed?
Difficult to understand error messages related to invalid characters in VARIABLES names, no information about where the issue is in the eCalc model.
What does this pull request change?
Included validation errors of type
string_pattern_mismatchinto CUSTOM_MESSAGES, to ensure better and customized feedback to user for these kind of errors.Issues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-647?atlOrigin=eyJpIjoiZmY2NzNlNWE2NTdjNGE5MjhmOTEzYWZlNzQ2Yjg4MzEiLCJwIjoiaiJ9