feat: implement adjustment factors for genset #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ECALC-1369
TeeeJay
reviewed
Jul 29, 2024
| @@ -10,10 +10,16 @@ def __init__( | |||
| self, | |||
| data_transfer_object: dto.GeneratorSetSampled, | |||
| ): | |||
| fuel_values = data_transfer_object.fuel_values | |||
There was a problem hiding this comment.
We are probably doing it the same way other places, but I think that this "manipulation" of the data should be done earlier, when reading the data. Why? Because we alter the data(-file), and not the model itself. If the data file is used other places/for other things, it should still be applied. In theory a file can be used more than one place. Please let me know what you think.
There was a problem hiding this comment.
Although, the way it has been implemented, sending the adjustment factor and constant to the genset, it makes sense to put here...
TeeeJay
approved these changes
Jul 31, 2024
equinor-schen
pushed a commit
that referenced
this pull request
Aug 23, 2024
* feat: implement adjustment factors for genset ECALC-1369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECALC-1369
Have you remembered and considered?
ECALC-XXXX)Why is this pull request needed?
Adjustment factor and adjustment constant are not implemented for genset. It is already implemented as a part of facility inputs.
What does this pull request change?
Make sure fuel consumption is scaled according to the adjustment factor and constant given in facility inputs.
Issues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-1369?atlOrigin=eyJpIjoiM2MxNDJhZjNhZDkyNDUzMGExODg3NjJiNzYzMzg3MmQiLCJwIjoiaiJ9