fix: read requested pressures in compressor system #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ECALC-1230
ECALC-1230
ECALC-1230
ECALC-1230
TeeeJay
reviewed
Aug 5, 2024
src/tests/libecalc/dto/results/model/test_requested_pressures_compressors.py
Show resolved
Hide resolved
TeeeJay
reviewed
Aug 5, 2024
TeeeJay
requested changes
Aug 5, 2024
ECALC-1230
ECALC-1230
TeeeJay
reviewed
Aug 6, 2024
TeeeJay
reviewed
Aug 6, 2024
TeeeJay
reviewed
Aug 6, 2024
TeeeJay
approved these changes
Aug 6, 2024
TeeeJay
approved these changes
Aug 6, 2024
Done |
frodehk
deleted the
ECALC-1230-fix-requested-pressures-compressor-system
branch
equinor-schen
pushed a commit
that referenced
this pull request
Aug 23, 2024
* fix: read requested pressures in compressor system ECALC-1230 --------- Co-authored-by: Thomas Falch Johansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECALC-1230
Have you remembered and considered?
ECALC-XXXX)Why is this pull request needed?
eCalc fails when extracting requested pressures from compressor system, if the date for the temporal model is not included in the timesteps for the input data.
What does this pull request change?
Update method for extracting requested pressures.
Issues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-1230?atlOrigin=eyJpIjoiNTFiNjQ5ZTI2N2ZiNDY5YmJjZGZiM2M3YjM0OGM3YzYiLCJwIjoiaiJ9