chore!: do not allow 0 efficiency in input chart #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsolaas
approved these changes
Aug 9, 2024
equinor-schen
pushed a commit
that referenced
this pull request
Aug 23, 2024
* chore: do not allow 0 efficiency in input chart ECALC-977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: 0 efficiency is not allowed in input charts.
ECALC-977
Have you remembered and considered?
BREAKING:in footer or!in header, if breakingECALC-XXXX)Why is this pull request needed?
Errors with 0 efficiency in input chart is catched late, and the error message does not point to the actual input file with the problem.
What does this pull request change?
Do not allow 0 efficiency in input file. It will give feedback much earlier, and points to the relevant file.
Issues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-977?atlOrigin=eyJpIjoiZDljMWJlYTczYzhjNGMwMTliM2FjNjU2YzVlNzJlNTAiLCJwIjoiaiJ9