Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change typ to rate_type for TimeSeriesRate #89

Merged
merged 1 commit into from
Sep 12, 2023
Merged

refactor: change typ to rate_type for TimeSeriesRate #89

merged 1 commit into from
Sep 12, 2023

Conversation

olelod
Copy link
Contributor

@olelod olelod commented Jun 23, 2023

No description provided.

@olelod olelod requested a review from a team as a code owner June 23, 2023 06:53
@olelod olelod force-pushed the rename-typ-to-ratetype-for-timeseriesrate branch from a87b3ea to 9245d3d Compare June 23, 2023 06:54
TeeeJay
TeeeJay reviewed Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@TeeeJay TeeeJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helt enig i at dette endres på, at typ var "intetsigende". Det er dog breaking, så foreslår å vente bittelitt med denne

@TeeeJay TeeeJay added the Breaking Change breaking change in input or output. To be aware of wrt setting next major/minor version. label Jun 29, 2023
@TeeeJay
Copy link
Collaborator

TeeeJay commented Aug 30, 2023

@jsolaas review this? Can add to v8.4

jsolaas
jsolaas approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@jsolaas jsolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We need web changes to merge this, maybe @krisolba1 could create a PR in web when she is done with the conversion feature?

@olelod olelod force-pushed the rename-typ-to-ratetype-for-timeseriesrate branch from 9245d3d to 6eab2fb Compare September 12, 2023 08:39
@olelod olelod merged commit 8be87dd into main Sep 12, 2023
6 checks passed
@olelod olelod deleted the rename-typ-to-ratetype-for-timeseriesrate branch September 12, 2023 08:47
@github-actions github-actions bot mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeeeJay TeeeJay TeeeJay left review comments

@jsolaas jsolaas jsolaas approved these changes

Assignees
No one assigned
Labels
Breaking Change breaking change in input or output. To be aware of wrt setting next major/minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olelod @TeeeJay @jsolaas