Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json schema allow stages to have control_margin and control_marg… #90

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

krisolba1
Copy link
Contributor

…in_unit

for SIMPLIFIED_VARIABLE_SPEED_COMPRESSOR_TRAIN

What does this pull request change?

JSON Schema for SIPLIFIED_VARIABLE_SPEED_COMPRESSOR_TRAIN should allow for stages to have CONTROL_MARGIN

@krisolba1 krisolba1 requested a review from a team as a code owner June 23, 2023 09:19
…in_unit

for SIMPLIFIED_VARIABLE_SPEED_COMPRESSOR_TRAIN
@krisolba1 krisolba1 merged commit 2415534 into main Jun 23, 2023
@krisolba1 krisolba1 deleted the fix/issue-4650 branch June 23, 2023 10:09
krisolba1 added a commit that referenced this pull request Jun 26, 2023
…in_unit (#90)

for SIMPLIFIED_VARIABLE_SPEED_COMPRESSOR_TRAIN
krisolba1 added a commit that referenced this pull request Jun 26, 2023
* fix: json schema accepts MAXIMUM_DISCHARGE_PRESSURE for single speed train (#86)

when PRESSURE_CONTROL is DOWNSTREAM_CHOKE

* fix: json schema allow stages to have control_margin and control_margin_unit (#90)

for SIMPLIFIED_VARIABLE_SPEED_COMPRESSOR_TRAIN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants