From b974250b2641a6501815cd62e8aa2369f3b6b388 Mon Sep 17 00:00:00 2001 From: Ruben Date: Mon, 5 Sep 2022 15:41:02 +0200 Subject: [PATCH 1/2] Added missing ID and key props. --- .../WebvizSettingsDrawer/components/ViewList/view-list.tsx | 5 ++++- .../components/WebvizSettingsGroup/WebvizSettingsGroup.tsx | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/react/src/lib/components/WebvizSettingsDrawer/components/ViewList/view-list.tsx b/react/src/lib/components/WebvizSettingsDrawer/components/ViewList/view-list.tsx index d40c723d..12955ca4 100644 --- a/react/src/lib/components/WebvizSettingsDrawer/components/ViewList/view-list.tsx +++ b/react/src/lib/components/WebvizSettingsDrawer/components/ViewList/view-list.tsx @@ -126,7 +126,10 @@ export const ViewList: React.FC = (props: ViewListProps) => { ); } else { return ( -
+
{el.group}
diff --git a/react/src/lib/components/WebvizSettingsGroup/WebvizSettingsGroup.tsx b/react/src/lib/components/WebvizSettingsGroup/WebvizSettingsGroup.tsx index 1a937fc8..44255b3c 100644 --- a/react/src/lib/components/WebvizSettingsGroup/WebvizSettingsGroup.tsx +++ b/react/src/lib/components/WebvizSettingsGroup/WebvizSettingsGroup.tsx @@ -133,6 +133,7 @@ export const WebvizSettingsGroup: React.FC = ( return (
From b8aaac5c6dc62d4ef5754f8ff19524f02f233eab Mon Sep 17 00:00:00 2001 From: Ruben Date: Mon, 5 Sep 2022 16:40:46 +0200 Subject: [PATCH 2/2] Adjusted changelog. --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b50a6460..047d7264 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - [#219](https://github.com/equinor/webviz-core-components/pull/219) - Implemented components required by the new Webviz Layout Framework (WLF) - [#227](https://github.com/equinor/webviz-core-components/pull/227) - Added `EdsIcon` component in order to use icons from the Equinor Design System (EDS) directly in Python. - [#240](https://github.com/equinor/webviz-core-components/pull/240) - States of menu, active view, settings drawer and settings groups are getting stored now. If no URL path is given, the one of the first page is opened now. +- [#248](https://github.com/equinor/webviz-core-components/pull/248) - Added missing `id` in `WebvizSettingsGroup` and `key` in `WebvizViewList` (for view groups). ### Changed