Extract template compilation from loadTemplate() to compileTemplate()
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a hook for customizing how templates are compiled, allowing for pre- and post- processing of templates compiled by the Handlebars compiler. Fixes #39
ghost
assigned 
|
|
||
| callback(null, compiledTemplate); | ||
| }, | ||
|
|
||
| loadPartials: function (options, callback) { |
There was a problem hiding this comment.
were you planning on calling the public method createTemplate() as per the title of the pull request or was that a typo?
There was a problem hiding this comment.
What do you mean? Where's the typo?
There was a problem hiding this comment.
The title being: Extract template compilation from loadTemplate() to createTemplate() There's no createTemplate method that you added or part of your module. Was just wondering if you had planned to call it that or not.
There was a problem hiding this comment.
Ah yeah, typo, meant to say compileTemplate().
|
Closing in favor of #68 (Rewrite with Promises). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a hook for customizing how templates are compiled, allowing for pre- and post- processing of templates compiled by the Handlebars compiler.
Fixes #39
Todos