Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow extensions to be named without a period #51

Merged
merged 1 commit into from
Jan 25, 2014

Conversation

calvinmetcalf
Copy link
Contributor

like the extension naming in express.

@ericf
Copy link
Owner

ericf commented Jan 24, 2014

Is there a problem you ran into? IIRC Express supports with/without the leading dot.

@calvinmetcalf
Copy link
Contributor Author

yes express supports both but but this library only supports with a dot meaning code like this

app.engine('hbs', handlebars({
    defaultLayout: 'main',
    extname: 'hbs'
}));

fails and needs to be written like this

app.engine('hbs', handlebars({
    defaultLayout: 'main',
    extname: '.hbs'
}));

source: I ran into this problem yesterday (assuming I could use the upper code) when trying to use your otherwise fine module, then my coworker did the exact same thing like 20 minutes later.

ericf added a commit that referenced this pull request Jan 25, 2014
allow extensions to be named without a period
@ericf ericf merged commit 5308fc8 into ericf:master Jan 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants