Fix partial name with namespace #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because namespace assignment was occurring after dir = dir.dir, there was never a dir.namespace. Had to put namespace before dir get its new value. Also went ahead and added some unit tests
|
Thanks for finding this! I merged in just the fix, because adding a test suite is out of the scope of this change. Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because namespace assignment was occurring after
dir = dir.dir,there was never a
dir.namespace. Had to put namespace before dirget its new value.
Also I took the liberty of adding an unit test for this bug fix.
PS: I work at Yahoo.