Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewing, reviewed, and the magical +1 #1

Open
jhermes opened this issue Aug 3, 2010 · 0 comments
Open

Reviewing, reviewed, and the magical +1 #1

jhermes opened this issue Aug 3, 2010 · 0 comments

Comments

@jhermes
Copy link
Contributor

jhermes commented Aug 3, 2010

Wouldn't it be nice if confirming that you're reviewing bug #N set a review field to your name in the Jira defect?

"jbellis: jhermes, can you review #N?"
"jhermes: reviewing #N"
-ding-

Wouldn't it be nice if when you said you were done reviewing, that moved it into a reviewed/ready for commit state?

"jhermes: jbellis: #N reviewed."
-ding-

Wouldn't it be nice if when you reviewed a patch (whether or not you were the main reviewer), a +1 added you to the list of people who reviewed #N?

"jhermes: jbellis: #N reviewed. +1"
"mdennis: #N +1"
"stuhood: #N +1"
-ding ding ding-

driftx referenced this issue in driftx/cassbot Nov 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant