-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for posting the html instead of adding a url #2
Comments
I'm yet to play around with this, but it could potentially work as-is if you converted the HTML to a data URI string and used that as the URL. This might be a terrible suggestion, but occurred to me that it could work. :) |
Actually if you paste a non-url to So either
|
@esbenp okay
|
I think either is a valid option. Personally I like a fewer, configurable endpoints. I will look into this soon |
You need only check
and open the URL... I think it would not be difficult to implement it. |
Actually if the html is really vast "PayloadTooLargeError: request entity too large" error can happen. Probably it might be solved by putting some configs for large requests within pdf-bot api express app. |
I think it would be reasonable to make it possible to generate the pdf's directly from html instead of from visiting a url.
Not sure how
html-pdf-chrome
handles this, but Puppeteer has support out of the box, so it should be possible.The text was updated successfully, but these errors were encountered: