Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages get truncated in MAM #1822

Closed
arcusfelis opened this issue Apr 24, 2018 · 1 comment
Closed

Messages get truncated in MAM #1822

arcusfelis opened this issue Apr 24, 2018 · 1 comment

Comments

@arcusfelis
Copy link
Contributor

MongooseIM version: 2.3 and below
Installed from: any
Erlang/OTP version: any

Max BLOB length is 65535 in mysql. Consider MEDIUMBLOB.
The data would be truncated silently by default.

We can enable SQL strict mode that would raise an error, if a too long string is inserted (instead of corrupting data).
https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#sqlmode_strict_all_tables

Tech info

Be aware, that "Strict mode" should be tested with batch queries.
For batch queries, only one bad field can cause whole batch cancelled - in this case we can retry the query using batch size=1.

It's good to test max field sizes in rdbms_SUITE from #1816.

@fenek
Copy link
Member

fenek commented Jun 6, 2018

Fixed in 3.0.0

@fenek fenek closed this as completed Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants