Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepared queries - DRAFT 2 #3025

Closed
wants to merge 90 commits into from
Closed

Prepared queries - DRAFT 2 #3025

wants to merge 90 commits into from

Commits on Feb 5, 2021

  1. Use prepared queries for message retraction

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    1eaf9d6 View commit details
    Browse the repository at this point in the history

  2. Make lookups prepared in mod_mam

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    5deea9b View commit details
    Browse the repository at this point in the history

  3. Reorder function in mod_mam_rdbms_arch.erl

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    fa55d70 View commit details
    Browse the repository at this point in the history

  4. Convert gdpr query to prepared

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    82d5a26 View commit details
    Browse the repository at this point in the history

  5. ADd maybe_reserve helper

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    d2dff9e View commit details
    Browse the repository at this point in the history

  6. Compactify code for do_lookup_messages

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    bf7e379 View commit details
    Browse the repository at this point in the history

  7. Adress review commits

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    cba1489 View commit details
    Browse the repository at this point in the history

  8. Use lookup_field record in mod_mam_rdbms_arch

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    9c1cd65 View commit details
    Browse the repository at this point in the history

  9. Refactor opt_count logic (less black magic)

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    075f01c View commit details
    Browse the repository at this point in the history

  10. Add Index Hint

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    12f38fd View commit details
    Browse the repository at this point in the history

  11. Reorder code

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    7662cd7 View commit details
    Browse the repository at this point in the history

  12. Add db_mappings

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    449a697 View commit details
    Browse the repository at this point in the history

  13. Remove GDPR helpers - use standard functions

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    eccad30 View commit details
    Browse the repository at this point in the history

  14. Make prepare_value pure by introducing env_vars

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    9a03005 View commit details
    Browse the repository at this point in the history

  15. Use env_vars for lookups

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    c34bc62 View commit details
    Browse the repository at this point in the history

  16. Use env_vars for retraction

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    a44b2c7 View commit details
    Browse the repository at this point in the history

  17. Use generic lookup for GDPR data extraction in mod_mam

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    60abce3 View commit details
    Browse the repository at this point in the history

  18. Shorten calc_count specs

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    e432f9a View commit details
    Browse the repository at this point in the history

  19. Add specs for with_env functions

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    11bb92c View commit details
    Browse the repository at this point in the history

  20. Use lookup_query for archive_size

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    0074bcf View commit details
    Browse the repository at this point in the history

  21. Pass env into lookup_query

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    c260175 View commit details
    Browse the repository at this point in the history

  22. Put RSM logic into mam_lookup

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    4047ef4 View commit details
    Browse the repository at this point in the history

  23. Prettify mam_lookup

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    10b89b8 View commit details
    Browse the repository at this point in the history

  24. Put code on one line where is possible in mod_mam_rdbms_arch

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    45fc7ef View commit details
    Browse the repository at this point in the history

  25. Move some code into encode_search_body

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    82f06a5 View commit details
    Browse the repository at this point in the history

  26. Reorder some functions

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    a004b4a View commit details
    Browse the repository at this point in the history

  27. Move unescape_binary into decode_packet

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    d00636b View commit details
    Browse the repository at this point in the history

  28. Move some code into mam_filter and mam_lookup_sql

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    a63e56e View commit details
    Browse the repository at this point in the history

  29. Rename some env fields

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    f73537b View commit details
    Browse the repository at this point in the history

  30. Put env getters on top of mam_lookup_sql

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    e5ab9dc View commit details
    Browse the repository at this point in the history

  31. Split make_tombstone function

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    329da67 View commit details
    Browse the repository at this point in the history

  32. Move some code into mam_encoder

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    5c4610f View commit details
    Browse the repository at this point in the history

  33. Use Ext prefix in decoders

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    f124125 View commit details
    Browse the repository at this point in the history

  34. Move common code into mam_decoder

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    26256d7 View commit details
    Browse the repository at this point in the history

  35. Reorder code in mod_mam_rdbms_arch

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    9d9f458 View commit details
    Browse the repository at this point in the history

  36. Use generic logic for mod_mam_muc_rdbms_arch

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    6a791c4 View commit details
    Browse the repository at this point in the history

  37. Address review comments

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    f185a92 View commit details
    Browse the repository at this point in the history

  38. Pass Offset and Limit as a separate arg

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    446f625 View commit details
    Browse the repository at this point in the history

  39. Fix GDPR MAM MUC query

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    0667308 View commit details
    Browse the repository at this point in the history

  40. Improve type specs

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    c97fa58 View commit details
    Browse the repository at this point in the history

  41. Remove unused column ids

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    87b0ae2 View commit details
    Browse the repository at this point in the history

  42. Order MAM MUC GDPR messages by ID

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    18e4468 View commit details
    Browse the repository at this point in the history

  43. Rename limit_offset_to_args to offset_limit_to_args

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    c03619c View commit details
    Browse the repository at this point in the history

  44. Fix mam_muc_extract_gdpr_messages on MSSQL

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    1d7603b View commit details
    Browse the repository at this point in the history

  45. Define mod_mam_rdbms_arch:env_vars() type

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    1093095 View commit details
    Browse the repository at this point in the history

  46. Replace lower with less

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    fe77da1 View commit details
    Browse the repository at this point in the history

  47. Use boolean type for lookup_field.required field

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    a6edd28 View commit details
    Browse the repository at this point in the history

  48. ADd specs for decoder/encoder

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    a214f42 View commit details
    Browse the repository at this point in the history

  49. Remove mod_mam_utils:get_retract_id/3

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    2f4d8e4 View commit details
    Browse the repository at this point in the history

  50. Apply code review comments

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    8cbfb25 View commit details
    Browse the repository at this point in the history

  51. Add mongoose_rdbms:execute_successfully 

    Address review comments
    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    b5e0d64 View commit details
    Browse the repository at this point in the history

  52. Pass binary into mongoose_rdbms:prepare/4 from mam modules

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    9f4d1c9 View commit details
    Browse the repository at this point in the history

  53. Store statement as binary in prepared_statements ETS table 

    So, we can more easily print it
Also, ets-lookup logic would run a bit faster for big iolists
    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    33a85ba View commit details
    Browse the repository at this point in the history

  54. Use prepared queries in mod_mam_rdbms_user

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    c9e98e7 View commit details
    Browse the repository at this point in the history

  55. Convert mod_mam_rdbms_prefs to prepared queries

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    49275d8 View commit details
    Browse the repository at this point in the history

  56. Declare queries in INSERT, SELECT, DELETE order

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    a203b7f View commit details
    Browse the repository at this point in the history

  57. Do not start mod_mam_rdbms_user for elasticsearch_and_cassandra_mnesi… 

    …a preset in big tests
    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    77f4964 View commit details
    Browse the repository at this point in the history

  58. Move transaction_with_delayed_retry/3 into mongoose_rdbms

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    214ff4d View commit details
    Browse the repository at this point in the history

  59. Move sql queries into mod_roster_rdbms

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    64e1e78 View commit details
    Browse the repository at this point in the history

  60. Remove mod_mam_utils:success_sql_query/2

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    367dbb3 View commit details
    Browse the repository at this point in the history

  61. Use prepared queries in mod_roster 

    Merge logic for queries with and without transactions.
There is no need to do transaction checking in the roster code.
This is already done in mongoose_rdbms.
    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    2adf351 View commit details
    Browse the repository at this point in the history

  62. Properly decode subscription and ask fields in mod_roster_rdbms

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    48a2600 View commit details
    Browse the repository at this point in the history

  63. Remove unused roster_sub_get_by_jid query

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    8a6bc38 View commit details
    Browse the repository at this point in the history

  64. Simplify error handling in mod_roster_rdbms 

    Require database jid to be parsable
    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    5f2e6d7 View commit details
    Browse the repository at this point in the history

  65. Edit comment for character_to_integer

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    3c0ccb1 View commit details
    Browse the repository at this point in the history

  66. Use prepared queries in mod_privacy_rdbms

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    45f94ff View commit details
    Browse the repository at this point in the history

  67. Make select_room_id/select_room_id_and_version prepared

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    0a8789e View commit details
    Browse the repository at this point in the history

  68. Split create_room function into two 

    Prepare query for muc_light_insert_room function
    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    0530760 View commit details
    Browse the repository at this point in the history

  69. Use prepared query for update_room_version and delete_room functions

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    ccac7a3 View commit details
    Browse the repository at this point in the history

  70. Use prepared function for select_affs/2 in MUC-light

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    243c616 View commit details
    Browse the repository at this point in the history

  71. Use prepared function for select_affs/1 in MUC-light

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    d7ec037 View commit details
    Browse the repository at this point in the history

  72. Add decode_affs/1 function

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    fb3bf67 View commit details
    Browse the repository at this point in the history

  73. User prepared insert_aff function

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    0d0caf5 View commit details
    Browse the repository at this point in the history

  74. User prepared update_aff function

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    943dbc3 View commit details
    Browse the repository at this point in the history

  75. Use prepared delete_aff/delete_affs functions

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    a03955b View commit details
    Browse the repository at this point in the history

  76. Make get_config function prepared

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    261e5ae View commit details
    Browse the repository at this point in the history

  77. Use prepared functions for insert, update and delete room configs

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    8ae524b View commit details
    Browse the repository at this point in the history

  78. Use prepared queries for muc-light blocking

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    6ed98cf View commit details
    Browse the repository at this point in the history

  79. Fix types for affiliations

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    93114ee View commit details
    Browse the repository at this point in the history

  80. Fix muc-light queries for ODBC

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    c91fdf7 View commit details
    Browse the repository at this point in the history

  81. Fix comment and typespec based on review

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    c3cb438 View commit details
    Browse the repository at this point in the history

  82. Fix indention in mod_muc_light_db_rdbms

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    1d4f143 View commit details
    Browse the repository at this point in the history

  83. Replace find_key with field_to_odbc_type

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    3b6a716 View commit details
    Browse the repository at this point in the history

  84. Ensure we match everything in create_room_transaction LCs

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    7fd536c View commit details
    Browse the repository at this point in the history

  85. Use prepared queries for mod_last

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    abc5a1a View commit details
    Browse the repository at this point in the history

  86. Remove unused rdbms_queries:update/5 function

    @arcusfelis
    arcusfelis committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    c7974d7 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Insert only a diff of privacy_data 

    Retry privacy update transaction
Update eodbc. Return bigints as numbers, not binaries now.
Smaller data type for the ord field.
    @arcusfelis
    arcusfelis committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    6b3306f View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3034 from esl/mu-prepared-queries-privacy-set-fix 

    Insert only a diff of privacy_data
    @chrzaszcz
    chrzaszcz committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    4cfbea6 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Use prepared queries for mod_muc_db_rdbms

    @arcusfelis
    arcusfelis committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    03006ce View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Merge pull request #3028 from esl/mu-prepared-queries-muc-2 

    Use prepared queries for MUC legacy - version 2
    @DenysGonchar
    DenysGonchar committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    872c8f2 View commit details
    Browse the repository at this point in the history