-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mod_event_pusher_push MUC Light error #3526
Conversation
This caused problems with stanzas addressed to a room.
small_tests_24 / small_tests / f2843c8 small_tests_23 / small_tests / f2843c8 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / f2843c8 dynamic_domains_mysql_redis_24 / mysql_redis / f2843c8 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / f2843c8 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / f2843c8 ldap_mnesia_23 / ldap_mnesia / f2843c8 ldap_mnesia_24 / ldap_mnesia / f2843c8 internal_mnesia_24 / internal_mnesia / f2843c8 mssql_mnesia_24 / odbc_mssql_mnesia / f2843c8 pgsql_mnesia_23 / pgsql_mnesia / f2843c8 mysql_redis_24 / mysql_redis / f2843c8 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / f2843c8 pgsql_mnesia_24 / pgsql_mnesia / f2843c8 riak_mnesia_24 / riak_mnesia / f2843c8 |
Codecov Report
@@ Coverage Diff @@
## master #3526 +/- ##
=======================================
Coverage 81.06% 81.07%
=======================================
Files 419 419
Lines 32297 32298 +1
=======================================
+ Hits 26183 26187 +4
+ Misses 6114 6111 -3
Continue to review full report at Codecov.
|
When a stanza was addressed to a room, there were errors in the logs due to a failed hook
filter_local_packet
running withTo
being the sender (mod_event_pusher:push_event/3
failed on the ETS lookup, because the name was expecting a Host, not a MUC Light host). The problem originates from the fact, thatfilter_local_packet
is called twice when processing a MUC Light message (see the comment).From what I understand, this change would mean that the notification will be processed (maybe tried to be sent?) in the context of the room - "to" the room itself.